Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore CBOR tags #2273

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Add option to ignore CBOR tags #2273

merged 3 commits into from
Jul 17, 2020

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Jul 15, 2020

This issue implements a proposal to address #1968. CBOR tags can be ignored then. To avoid breaking changes, the default will still throw a parse error. A treatment of CBOR tags is also the prerequisite of #2244.

Closes #1968.

@nlohmann nlohmann marked this pull request as draft July 15, 2020 12:25
@nlohmann nlohmann mentioned this pull request Jul 15, 2020
4 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 93cdf05 on issue1968 into 1a521cb on develop.

@nlohmann nlohmann marked this pull request as ready for review July 16, 2020 11:29
@nlohmann nlohmann self-assigned this Jul 16, 2020
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 16, 2020
@nlohmann nlohmann merged commit 548e7e5 into develop Jul 17, 2020
@nlohmann nlohmann deleted the issue1968 branch July 17, 2020 12:00
@nlohmann
Copy link
Owner Author

nlohmann commented Jul 17, 2020


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBOR parser doesn't skip tags
2 participants