Treat MSVC warnings as errors #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gregmarr
reviewed
Aug 13, 2021
test/src/unit-allocator.cpp
Outdated
| @@ -100,6 +100,9 @@ struct my_allocator : std::allocator<T> | |||
| std::allocator<T>::deallocate(p, n); | |||
| } | |||
|
|
|||
| // the code below warns about p in MSVC 2015 - this could be a bug | |||
There was a problem hiding this comment.
"C4100 can also be issued when code calls a destructor on a otherwise unreferenced parameter of primitive type. This is a limitation of the Microsoft C++ compiler."
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4100?view=msvc-160
gregmarr
reviewed
Aug 13, 2021
test/src/unit-udt.cpp
Outdated
| @@ -809,6 +809,10 @@ TEST_CASE("an incomplete type does not trigger a compiler error in non-evaluated | |||
| static_assert(!is_constructible_patched<json, incomplete>::value, ""); | |||
| } | |||
|
|
|||
| // the code below warns about t in MSVC 2015 - this could be a bug | |||
| DOCTEST_MSVC_SUPPRESS_WARNING_PUSH | |||
There was a problem hiding this comment.
Same class of error as the other one, sizeof(t) is a compile-time constant based only on T, not on the value of t.
There was a problem hiding this comment.
Thanks, I also fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #2924 and treats all MSVC warnings as errors.