Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwork documentation #3444

Merged
merged 20 commits into from
Apr 25, 2022
Merged

Overwork documentation #3444

merged 20 commits into from
Apr 25, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Apr 16, 2022 •
edited
Loading

  • Added dedicated pages for macros with lots of examples.
  • Added dedicated page on runtime assertions.
  • Fixed some outdated URLs.
  • Added more links between the general documentation and the API documentation.

(There are possibly lots of typos in there...)

@nlohmann nlohmann marked this pull request as draft April 16, 2022 20:44
@coveralls
Copy link

coveralls commented Apr 16, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3e03486 on overwork_documentation into 1a90c94 on develop.

@nlohmann nlohmann marked this pull request as ready for review April 23, 2022 21:55
@nlohmann nlohmann added review needed It would be great if someone could review the proposed changes. documentation labels Apr 23, 2022
@nlohmann nlohmann mentioned this pull request Apr 24, 2022
Open
@nlohmann
Copy link
Owner Author

I made some more minor changes, but this PR is basically done.

@falbrechtskirchinger
Copy link
Contributor

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 25, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Apr 25, 2022
@falbrechtskirchinger
Copy link
Contributor

Sorry. I should use the queue feature.

falbrechtskirchinger
falbrechtskirchinger approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! :-)

@nlohmann nlohmann merged commit a6ee8bf into develop Apr 25, 2022
@nlohmann nlohmann deleted the overwork_documentation branch April 25, 2022 20:40
@nlohmann
Copy link
Owner Author

Thanks @falbrechtskirchinger @gregmarr for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr left review comments

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation review needed It would be great if someone could review the proposed changes.
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nlohmann @coveralls @falbrechtskirchinger @gregmarr