Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly pop diagnostics #540

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Properly pop diagnostics #540

merged 2 commits into from
Mar 30, 2017

Conversation

tinloaf
Copy link

@tinloaf tinloaf commented Mar 30, 2017

Currently, with clang, the diagnostics are push()ed twice, but pop()ed only once. Fixing this by adding a "pragma diagnostics pop".

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.865% when pulling 0b1b630 on tinloaf:diagnostics into c2e80a7 on nlohmann:develop.

@nlohmann nlohmann self-assigned this Mar 30, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Mar 30, 2017
@nlohmann nlohmann merged commit 7881783 into nlohmann:develop Mar 30, 2017
@nlohmann
Copy link
Owner

Thanks!

nlohmann added a commit that referenced this pull request Mar 30, 2017
@nlohmann
📝 mentioned #540 and fixed #538
d07596a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
confirmed kind: bug
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tinloaf @coveralls @nlohmann