From 040186390473c43b04a4eb9728cb3bd1c76b322c Mon Sep 17 00:00:00 2001 From: Ryan Garant Date: Sat, 2 Nov 2019 18:47:42 -0700 Subject: [PATCH] fix(pull-request): only add body to fwd payload when it exists GitHub api expects you to not pass a body param if it is null or empty fix #709 --- src/cmds/pull-request.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cmds/pull-request.ts b/src/cmds/pull-request.ts index 9e96a5d4..e6820988 100755 --- a/src/cmds/pull-request.ts +++ b/src/cmds/pull-request.ts @@ -830,14 +830,15 @@ async function submit(options, user) { git.push(options.config.default_remote, pullBranch) var payload: any = { + mediaType: { + previews: ['shadow-cat'], + }, owner: user, base: options.branch, head: `${options.user}:${pullBranch}`, repo: options.repo, - mediaType: { - previews: ['shadow-cat'], - }, ...(options.draft ? { draft: options.draft } : {}), + ...(options.description ? { body: options.description } : {}), } try { @@ -845,7 +846,6 @@ async function submit(options, user) { payload.issue = options.issue var { data } = await options.GitHub.pulls.createFromIssue(payload) } else { - payload.body = options.description payload.title = options.title || git.getLastCommitMessage(pullBranch) var { data } = await options.GitHub.pulls.create(payload)