fix(pull-request): ensure description is passed correctly from editor

node-gh · Nov 4, 2019 · d7a457a · d7a457a
1 parent 68c55b1
commit d7a457a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -11,12 +11,12 @@
             "runtimeArgs": ["-r", "ts-node/register"],
             "args": [
                 "${workspaceFolder}/src/debug.ts",
-                "is",
-                "--new",
+                "pr",
+                "-s",
+                "protoEvangleion",
                 "--title",
-                "title",
-                "--message",
-                "mess"
+                "dont ask",
+                "--description"
             ],
             // "args": ["${workspaceFolder}/src/debug.ts", "ji", "LWM-117", "--status"],
             "console": "integratedTerminal"

diff --git a/src/cmds/pull-request.ts b/src/cmds/pull-request.ts
@@ -856,7 +856,7 @@ async function submit(options, user) {
         title: title,
         ...(options.issue ? { issue: options.issue } : {}),
         ...(options.draft ? { draft: options.draft } : {}),
-        ...(options.description ? { body: options.description } : {}),
+        ...(description ? { body: description } : {}),
     }
 
     try {

diff --git a/src/utils.ts b/src/utils.ts
@@ -26,7 +26,7 @@ export function openUrl(url) {
  */
 export function userLeftMsgEmpty(string: string): boolean {
     return (
-        string === '' ||
+        !string ||
         string === '--title' ||
         string === '-t' ||
         string === '--message' ||