fix: 🐛 redirect status code (#363)

Co-authored-by: hongcai.dhc <hongcai.dhc@alibaba-inc.com>
node-modules · Jul 5, 2021 · b730a6c · b730a6c
1 parent 27dc858
commit b730a6c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/lib/urllib.js b/lib/urllib.js
@@ -602,15 +602,14 @@ function requestWithCallback(url, args, callback) {
       timing.contentDownload = requestUseTime;
     }
 
-    var headers = {};
-    if (res && res.headers) {
-      headers = res.headers;
-    }
+    var headers = res && res.headers || {};
+    var resStatusCode = res && res.statusCode || statusCode;
+    var resStatusMessage = res && res.statusMessage || statusMessage;
 
     return {
-      status: statusCode,
-      statusCode: statusCode,
-      statusMessage: statusMessage,
+      status: resStatusCode,
+      statusCode: resStatusCode,
+      statusMessage: resStatusMessage,
       headers: headers,
       size: responseSize,
       aborted: responseAborted,

diff --git a/test/urllib.test.js b/test/urllib.test.js
@@ -1715,6 +1715,8 @@ describe('test/urllib.test.js', function () {
       });
       urllib.on('response', function (info) {
         if (info.req.options.path === '/302-to-200') {
+          assert(info.res.status === 302);
+          assert(info.res.statusCode === 302);
           redirected = true;
         }
         assert(info.req.options.headers['custom-header'] === 'custom-header');