Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate a fresh package-lock. #563

Closed
wants to merge 1 commit into from

Conversation

forty
Copy link
Contributor

@forty forty commented Mar 18, 2021

The current one was messed up by #560

Sorry for the mess

The current one was messed up by node-saml#560
@cjbarth
Copy link
Collaborator

cjbarth commented Mar 18, 2021

I have to take a close look at this because "refreshing" the package-lock.json will actually change the patch version of our dependencies, and that won't be documented. I think I might roll-back the two PRs that just landed and we can start over.

@forty
Copy link
Contributor Author

forty commented Mar 18, 2021

Makes sense. And that one seems to break the build too :/ so much for semver reliability :)

At least this time it breaks on my machine too

@cjbarth cjbarth closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants