Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(soundcue): fix soundcue files not persisting #584

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix(soundcue): fix soundcue files not persisting #584

merged 1 commit into from
Aug 20, 2021

Conversation

Sikarii
Copy link
Contributor

@Sikarii Sikarii commented Jul 9, 2021

This should fix soundcue files not persisting (see #581).
This fix should also be identical to the fix in branch dev-2.0.

Copy link
Contributor

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can verify that this fixes the issue. Thanks.
I've searched whether this was fixed in v2 before opening the issue but apparently missed #537...

@Hoishin Hoishin changed the title Fix soundcue files not persisting fix(soundcue): fix soundcue files not persisting Aug 20, 2021
@Hoishin Hoishin merged commit eeac8c4 into nodecg:master Aug 20, 2021
Hoishin added a commit to ExtremTechniker/nodecg that referenced this pull request Aug 20, 2021
* origin/master:
  fix(dashboard): correct URL for obs drag when login is enabled (nodecg#585)
  fix(soundcue): fix soundcue files not persisting (nodecg#584)
  feat(extension): allow extensions to export esmodule (nodecg#587)
  feat(auth): discord login option (nodecg#571)
Hoishin added a commit to Seldszar/nodecg that referenced this pull request Aug 20, 2021
…h-ids

* origin/master:
  fix(dashboard): correct URL for obs drag when login is enabled (nodecg#585)
  fix(soundcue): fix soundcue files not persisting (nodecg#584)
  feat(extension): allow extensions to export esmodule (nodecg#587)
  feat(auth): discord login option (nodecg#571)
Hoishin added a commit that referenced this pull request Aug 20, 2021
* origin/master:
  feat(login): add twitch id whitelisting (#583)
  fix(socket): correct maxListeners setting to prevent memory leak (#579)
  fix(dashboard): correct URL for obs drag when login is enabled (#585)
  fix(soundcue): fix soundcue files not persisting (#584)
  feat(extension): allow extensions to export esmodule (#587)
  feat(auth): discord login option (#571)
  chore(release): 1.8.1
  fix: better log formatting and configurable timestamps (#575)
  chore(deps): switch husky to 4
  fix(deps): fix some vulnerabilities of dependency
  chore(release): 1.8.0
  chore: update standard-version
  chore: remove old docs files
  ci: remove release job
  feat(replicants): remove local storage size quota (#574)
  ci: test on windows (#576)
@Sikarii Sikarii deleted the fix-581 branch August 20, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants