Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose code and learn session for node-addon-api testing #385

Closed
mhdawson opened this issue Sep 30, 2019 · 2 comments
Closed

Propose code and learn session for node-addon-api testing #385

mhdawson opened this issue Sep 30, 2019 · 2 comments
Milestone
Milestone 11

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 30, 2019 •
edited
Loading

Could use nodejs/node-addon-api#332 as the starting point.

In advance @NickNaso also suggested we write a doc on "adding a test"

Intro

  • What needs to be installed (share this in advance)
    (does the list already exist? same as for PR to node core)
  • Short intro to the tests, how to run

Would want to

  • Prioritize which ones to start with
@mhdawson mhdawson added this to the Milestone 11 milestone Sep 30, 2019
@mhdawson
Copy link
Member Author

PR for proposal: openjs-foundation/code-and-learn#5

@mhdawson
Copy link
Member Author

Code-and-learn did not happen so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
1 participant
@mhdawson