Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring ownership of node-vscode-config #260

Closed
trivikr opened this issue Nov 1, 2018 · 10 comments
Closed

Transferring ownership of node-vscode-config #260

trivikr opened this issue Nov 1, 2018 · 10 comments

Comments

@trivikr
Copy link
Member

trivikr commented Nov 1, 2018

Hi,

Earlier discussions in https://github.com/orgs/nodejs/teams/collaborators/discussions/58

The repo is already moved to nodejs as I followed the steps in documentation, and wasn't blocked. I wasn't aware of the policy which @Trott shared and following it now.

History:

  • I've been contributing to Node.js core for more than a year now, and have been using VSCode editor.
  • I'd created a node-vscode-config repo with VSCode launch config 7 months ago, and shared it with contributors in mini Code+Learn events. The devs whom I'd interacted with found it useful.

Proposal:

  • I would like to share this config with all the collaborators by moving it under nodejs organization.
  • Since Node.js core doesn't allow editor specific configs, the repo will continue to exist independently and we'll link it from Node core documentation. Collaborators can add VSCode specific configs later, or create other editor specific repos or rename this repo to include configs of other editors.

Regards,
Trivikram

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2018

The repo is already moved under nodejs org, and I don't see an option to transfer it back to myself.
If you're an owner and would want the ownership to lie with me till the decision is taken on this issue, then please follow the documentation to initiate the transfer of node-vscode-config back to me.

@devsnek
Copy link
Member

devsnek commented Nov 1, 2018

can multiple editor configs be held in one repo? a repo just for vscode seems a bit extreme.

@Trott
Copy link
Member

Trott commented Nov 1, 2018

The repo needs a LICENSE file and a Code of Conduct.

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2018

@devsnek Yeah, we can rename the repo (to node-editor-config for example) and create a folder for each editor where configs can be stored?

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2018

@Trott Is there a recommendation for adding LICENSE
I couldn't find one in https://github.com/nodejs/admin/search?q=license&unscoped_q=license

I've added link to admin CODE_OF_CONDUCT in PR nodejs/node-code-ide-configs#2

@Trott
Copy link
Member

Trott commented Nov 1, 2018

@trivikr Looks like the PR with that information has not yet landed. However, maybe https://github.com/nodejs/admin/pull/68/files will be helpful? It doesn't say what LICENSE is acceptable, but the main repo uses MIT license, so I imagine that would be an easy 👍.

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2018

Added MIT License in nodejs/node-code-ide-configs#3

@refack
Copy link
Contributor

refack commented Nov 1, 2018

A tad bit of name bikeshedding: I suggest node-code-ide-configs just to have it clear about its intended purpose.

@Trott
Copy link
Member

Trott commented Jul 8, 2019

It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Jul 8, 2019
@trivikr
Copy link
Member Author

trivikr commented Jul 8, 2019

The repo was renamed to node-code-ide-configs and now lies in nodejs org at https://github.com/nodejs/node-code-ide-configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants