-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move bnb/devenv to nodejs/devcontainer #641
Comments
cc @nodejs/tsc also @nodejs/docker potentially worth looking at this. I believe @Trott suggested that y'all might be a good set of stewards if you're okay with that. |
@bnb Feel free to put a |
+1 from me |
SGTM |
Based on discussion in the TSC meeting today and no objections in the issue believe we can move forward. @bnb if you make me an owner of the repo I can move it over. |
@bnb I think we can close this right? |
Yep! |
per nodejs/node#39672, it seems the next steps would be to move the bnb/devenv repository into the Node.js org and to PR the
.devcontainer
dir to nodejs/node. I'd recommend moving it to nodejs/devcontainer.One thing to note, we'd need to grab a Docker Hub token to publish it to the Node.js Docker Hub account to publish the image. I presume we'll want to publish it to
nodejs/devcontainer
to match the repo. We will need to choose some kind of name, which will need to be reflected in code here.Worth noting that this will consume some portion of our Actions minutes. In its first run, it took about an hour and a half to build and publish on the default 2 core runner. I've presently set it up to run nightly, though the cron can be changed through normal means in GitHub. I've talked a bit with the Actions team and it seems that we'd potentially be able to get dedicated runners for this workload - I'll follow up with them once we've moved the repo into the org ❤️
Happy to do this but want to get the appropriate approvals, of course :)
The text was updated successfully, but these errors were encountered: