-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub Codespaces for Node.js #808
Comments
cc @mhdawson |
SGTM as long as we have the budget for it and it is not abused. |
We should probably enable only specific repositories. Afaik, this is configurable. And we can keep track of the billing to see who users are potentially abusing the system. |
sgtm |
Do we need to add this to the TSC agenda, or is this sgtm enough to the point of simply requesting the Foundation to do it? Or are there any further details to be done? |
Probably a good idea to add it to a TSC agenda for awareness purposes, but also I'd consider open-for-5-days-with-2-approvals-from-TSC-members sufficient to make the request. And it SGTM too, so that's three TSC members. |
SGTM |
@Trott was there any review? Or any update? Or does |
|
Hmm, yeah I guess tsc-agenda then? |
@ovflowd can you confirm that if we enable, it will only be able to be used up to the $ that the Foundation has provided? If so then I'm STGM as well. |
Hey @mhdawson according to this https://github.com/openjs-foundation/cross-project-council/blob/main/project-resources/REQUESTING_GITHUB_RESOURCES.md, yes. (And I double-checked with Ben). He would need to be added as Billing Manager (as stated in the doc) and then we can put limits, limit how many codespaces each user can create, we can even limit which repositories can have codespaces (billed to the Node.js org) and even limit who can have access to it (if we want to make it opt-in) |
LGTM |
@mhdawson let me know once there's an update on the next TSC meeting, so depending of the outcome I'd be able to forward this to the CPC :) |
@ovflowd its on the agenda for the TSC meeting this week. I'll let you know the outcome of any discussion. |
SGTM, approved in today's TSC meeting |
Opened a PR on the Foundation's CPC repository: openjs-foundation/cross-project-council#1149 |
Recently, the OpenJS Foundation pivoted, enabling Codespaces Billing on the Webpack organisation (openjs-foundation/cross-project-council#1009). I'd like the same to be done on the Node.js organisation.
I can see clear benefits in productivity as we could access the large Codepsaces Runners and build Node.js on the cloud if needed. Also, it would bring benefits where collaborators are far from their development machines but could still contribute.
At least I'm already using it daily for the Website Team, but paying from my pocket.
I don't know if this needs TSC consensus. cc @nodejs/tsc
The text was updated successfully, but these errors were encountered: