-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint/cclint separately from make test #109
Comments
👍 for using linting as a gate for running full tests. |
Sounds like a plan, then. If no one objects, I'll setup a machine on DO shortly. |
We now have two linters. Each run seems to be around ~40 secs (on tree's that are relatively similar and lives in block cache). A cold tree run is about 1min 10sec. The vm's are run in New York and San Fransisco for redundancy. The final step is to have this project block the main project and merge nodejs/node#1965. |
Rolled into production a week ago. Closing. |
I've seen a job in jenkins fail once or twice because the lint at the end of testing fails. It'd be great if we could create a bot that first passes linting before passing it on to the "real" tests. Saving cpu cycles, quicker feedback to user, etc.
We already have
make lint
, but since it assumes iojs is available, this bot might have to be a bit "special". Also, I'm not sure how to set up jenkins this way.It would also work nice as a step in the github test notification feedback, but that's a later problem
The text was updated successfully, but these errors were encountered: