Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to install libcap on Linux CI machines #2599

Closed
danbev opened this issue Mar 30, 2021 · 6 comments
Closed

Request to install libcap on Linux CI machines #2599

danbev opened this issue Mar 30, 2021 · 6 comments

Comments

@danbev
Copy link
Contributor

danbev commented Mar 30, 2021

There is currently a draft PR nodejs/node#37727 which if accepted will add a build time dependency for Linux for libcap. This issue would like to request libcap be installed on the CI machines that use Linux.

The pull request includes updates to the github workflows and used the following command:

$ sudo apt-get install -y libcap-dev
@rvagg
Copy link
Member

rvagg commented Mar 30, 2021

Is that going to mean that libcap will be a runtime dependency for Node now? I'm imagining it's ubiquitous by now, but maybe not, do you know?

@mhdawson
Copy link
Member

@rvagg I think @danbev linked to it statically, through:

      [ 'OS in "linux"', {
        'ldflags': [ '-Wl,-Bstatic -Wl,--whole-archive -lcap -Wl,--no-whole-archive -Wl,-Bdynamic' ],
      }],

but I was wondering a bit about that.

@rvagg
Copy link
Member

rvagg commented Mar 31, 2021

OK, interesting. A test release build will also be interesting from a size perspective! But we'd have to get libcap on there too.

@danbev this is going to require a bit of ansible work unfortunately. Probably narrowing down the hosts where we run 16+ (or whatever base this is expected to flow back to) and updating the list of installed packages to include libcap-dev or its alternative name on the various platforms. Would you mind having a go at that? I can't tell you off the top of my head which file(s) to look at but I think there's a variables file in baselayout that might be the best place to start, you'll find it split up across OS+version.

@richardlau
Copy link
Member

We'd probably need to do the containers too.

@danbev
Copy link
Contributor Author

danbev commented Apr 6, 2021

Would you mind having a go at that?

Yeah I'll give it a shot, thanks.

danbev added a commit to danbev/build that referenced this issue Apr 6, 2021
This commit adds the libcap-dev package to linux distributions to
support the usage of Linux capabilities in Node.js.

Fixes: nodejs#2599
Refs: nodejs/node#37727
richardlau pushed a commit to danbev/build that referenced this issue Apr 9, 2021
This commit adds the libcap-dev package to linux distributions to
support the usage of Linux capabilities in Node.js.

Fixes: nodejs#2599
Refs: nodejs/node#37727
richardlau pushed a commit to danbev/build that referenced this issue Apr 9, 2021
This commit adds the libcap-dev package to linux distributions to
support the usage of Linux capabilities in Node.js.

Fixes: nodejs#2599
Refs: nodejs/node#37727
danbev added a commit to danbev/build that referenced this issue Jul 21, 2021
This commit adds the libcap-dev package to linux distributions to
support the usage of Linux capabilities in Node.js.

Fixes: nodejs#2599
Refs: nodejs/node#37727
@richardlau
Copy link
Member

Closing based on #2607 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants