-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop testing with osx1014 (v17+, master)? #2769
Comments
makes sense I had planned to add some intel big sur machines so I can just replace the 10.14 machines with them if there are no objections @nodejs/build? |
https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list does say that we support 10.13 and above so we might want to have some 10.13 with the newer xcode or bump up the minimum macOS level for 17.x ? |
Xcode 11 doesn't support 10.13. It looks like some versions of it support 10.14: https://en.wikipedia.org/wiki/Xcode#11.x_series |
10.13 is our compilation target - it should be that our binaries will work on it but we dont compile on it. |
@AshCripps thanks for the reminder, makes sense. I remember discussions around that and we've been ok in past not testing on the lower versions so what you suggest seems good to me. |
I don't know if it happened, but CI now passes with V8 9.5 so this is resolved from my PoV. |
It started to fail with V8 9.5:
nodejs/node#40178
https://ci.nodejs.org/job/node-test-commit-osx/42171/nodes=osx1014/console
The build output suggests that Xcode 10 is used on those hosts, but Node.js requirements are now Xcode >=11.
The text was updated successfully, but these errors were encountered: