-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --without-ssl node-test-commit job #643
Comments
Related #419 ( |
Related nodejs/node#11747 |
@jbergstroem @mhdawson could one of you clone one of the build jobs (node-test-commit-linux I guess) so I can try to get this set up? |
I assume you will cut it down to run on a single linux variant only, as we don't want to double the load and the one would probably be enough to catch compile problems. Cloned one for you to work on here: https://ci.nodejs.org/view/All/job/node-test-commit-linux-gibson/ |
This came up the other day but I don't recall where. @mhdawson & @danbev, where was that, IRC? Anyway, I tried one out, the config is all done and waiting to be enabled (by ticking the label "" to the list of node labels in the job) but it has a snag, perhaps the first of many? https://ci.nodejs.org/job/node-test-commit-linux-containered/3916/nodes=ubuntu1604_sharedlibs_withoutssl_x64/console (you'll have to scroll up a bit, above the addons)
Before it can be turned on, we're going to need to skip this step for this type of build. |
@maclover7 Awesome, thanks for that! |
See nodejs/node#11734, it would be useful to have some testing to catch the non-default build cases (there are probably more than just
--without-ssl
).The text was updated successfully, but these errors were encountered: