Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --without-ssl node-test-commit job #643

Closed
gibfahn opened this issue Mar 7, 2017 · 7 comments
Closed

Add a --without-ssl node-test-commit job #643

gibfahn opened this issue Mar 7, 2017 · 7 comments
Assignees

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 7, 2017

See nodejs/node#11734, it would be useful to have some testing to catch the non-default build cases (there are probably more than just --without-ssl).

@richardlau
Copy link
Member

Related #419 (--without-intl)

@sam-github
Copy link
Contributor

Related nodejs/node#11747

@gibfahn
Copy link
Member Author

gibfahn commented Mar 8, 2017

@jbergstroem @mhdawson could one of you clone one of the build jobs (node-test-commit-linux I guess) so I can try to get this set up?

@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2017

I assume you will cut it down to run on a single linux variant only, as we don't want to double the load and the one would probably be enough to catch compile problems.

Cloned one for you to work on here: https://ci.nodejs.org/view/All/job/node-test-commit-linux-gibson/

@rvagg
Copy link
Member

rvagg commented Apr 23, 2018

This came up the other day but I don't recall where. @mhdawson & @danbev, where was that, IRC?

Anyway, I tried one out, the config is all done and waiting to be enabled (by ticking the label "" to the list of node labels in the job) but it has a snag, perhaps the first of many? https://ci.nodejs.org/job/node-test-commit-linux-containered/3916/nodes=ubuntu1604_sharedlibs_withoutssl_x64/console (you'll have to scroll up a bit, above the addons)

make test-ci involves npm which tries to do an update check but fails because that loads crypto

09:36:53 Makefile:649: recipe for target 'tools/doc/node_modules/js-yaml/package.json' failed
09:36:53 make[2]: *** [tools/doc/node_modules/js-yaml/package.json] Error 1
09:36:53 Makefile:608: recipe for target 'doc-only' failed
09:36:53 make[1]: *** [doc-only] Error 2

Before it can be turned on, we're going to need to skip this step for this type of build.

@maclover7
Copy link
Contributor

This is a thing now: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_withoutintl_x64/

@danbev
Copy link
Contributor

danbev commented May 25, 2018

@maclover7 Awesome, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants