Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cctest failure in CI run #769

Closed
kunalspathak opened this issue Jun 24, 2017 · 3 comments
Closed

cctest failure in CI run #769

kunalspathak opened this issue Jun 24, 2017 · 3 comments

Comments

@kunalspathak
Copy link
Member

I noticed that cctest.exe run failure doesn't show as test failure. For e.g. here is the CI run triggered for node-chakracore and it says test pass even if test case inside cctest hits an assert. Is there any reason of not having a post-build action step to parse cctest.tap output similar to test.tap output?

I think on non-windows, the make job will anyway fail if cctest fails, so this is only problem for windows.

@joaocgreis
Copy link
Member

Looks like cctest.tap was not added to the Windows job as it probably should have been when it was added to others. It can be easily added, but only when cctest passes on Windows, to avoid breaking all runs.

@refack
Copy link
Contributor

refack commented Jul 6, 2017

ping nodejs/node#14111

@kunalspathak
Copy link
Member Author

Updated jenkins job : https://ci.nodejs.org/job/node-test-binary-windows/jobConfigHistory/showDiffFiles?timestamp1=2017-06-25_20-05-00&timestamp2=2017-07-21_12-36-26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants