You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that cctest.exe run failure doesn't show as test failure. For e.g. here is the CI run triggered for node-chakracore and it says test pass even if test case inside cctest hits an assert. Is there any reason of not having a post-build action step to parse cctest.tap output similar to test.tap output?
I think on non-windows, the make job will anyway fail if cctest fails, so this is only problem for windows.
The text was updated successfully, but these errors were encountered:
Looks like cctest.tap was not added to the Windows job as it probably should have been when it was added to others. It can be easily added, but only when cctest passes on Windows, to avoid breaking all runs.
I noticed that
cctest.exe
run failure doesn't show as test failure. For e.g. here is the CI run triggered fornode-chakracore
and it says test pass even if test case inside cctest hits an assert. Is there any reason of not having a post-build action step to parsecctest.tap
output similar totest.tap
output?I think on non-windows, the
make
job will anyway fail ifcctest
fails, so this is only problem for windows.The text was updated successfully, but these errors were encountered: