Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: the '-j' option requires a positive integer argument #857

Closed
silverwind opened this issue Aug 30, 2017 · 6 comments
Closed

make: the '-j' option requires a positive integer argument #857

silverwind opened this issue Aug 30, 2017 · 6 comments

Comments

@silverwind
Copy link

Noticed on this run:

https://ci.nodejs.org/job/node-test-commit-arm/11808/nodes=ubuntu1604-arm64_odroid_c2/console

I'm not sure why it fails on that target but maybe make -j $(nproc) is a better alternative on Linux.

@refack
Copy link
Contributor

refack commented Aug 30, 2017

Cross-ref: #841 (comment)

@gibfahn
Copy link
Member

gibfahn commented Aug 30, 2017

Yeah that seems like an issue with the machine and the test. We should probably default to 2/4 (2 on the arm machines seems more reasonable).

Changed the test from $JOBS to ${JOBS:-2}. I note there's also a comment from @jbergstroem saying that he changed it from $JOBS to 2, so that seems like a reasonable default.

@gibfahn
Copy link
Member

gibfahn commented Aug 30, 2017

Also @nodejs/build is $JOBS normally defined in the machine config? I was going to add it as an environment variable, but I couldn't see it in any of the others so wasn't sure that was correct.

@joaocgreis
Copy link
Member

It's in the start.sh script, that way it can be defined independently for each host.

The default shouldn't hurt.

@gibfahn
Copy link
Member

gibfahn commented Aug 31, 2017

I guess we need to work out why JOBS wasn't set on the machines.

@gibfahn
Copy link
Member

gibfahn commented Sep 1, 2017

So it turns out $JOBS wasn't undefined, it was actually set to 0.

You can see by running this in the script console (e.g. here)

println System.getenv("JOBS")

// Returns: 0

I've added this to the job, but the real fix would be to make sure that JOBS is never set to 0 in the start.sh script.

[ "$JOBS" = 0 ] && export JOBS=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants