-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: the '-j' option requires a positive integer argument #857
Comments
Cross-ref: #841 (comment) |
Yeah that seems like an issue with the machine and the test. We should probably default to 2/4 (2 on the arm machines seems more reasonable). Changed the test from |
Also @nodejs/build is |
It's in the start.sh script, that way it can be defined independently for each host.
The default shouldn't hurt. |
I guess we need to work out why |
So it turns out You can see by running this in the script console (e.g. here) println System.getenv("JOBS")
// Returns: 0 I've added this to the job, but the real fix would be to make sure that JOBS is never set to 0 in the start.sh script. [ "$JOBS" = 0 ] && export JOBS=2 |
Noticed on this run:
https://ci.nodejs.org/job/node-test-commit-arm/11808/nodes=ubuntu1604-arm64_odroid_c2/console
I'm not sure why it fails on that target but maybe
make -j $(nproc)
is a better alternative on Linux.The text was updated successfully, but these errors were encountered: