Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Change 4 Windows 2008 machines to Visual Studio 2017 #883

Closed
joaocgreis opened this issue Sep 14, 2017 · 3 comments
Closed
Assignees

Comments

@joaocgreis
Copy link
Member

All of our Windows 2008 test machines have Visual Studio 2013 installed: This ensures that the test-addons tests are run with VS2013, effectively testing VS2013 simultaneously with Windows 2008.

However, support for VS2013 was completely dropped in Node 9, but we still need to test Windows 2008. So, I plan to change 4 machines to the latest VS2017 and leave only 2 machines with VS2013 for LTS testing.

The current setup is already causing issues in nodejs/node#15362, so I plan to move forward very soon unless there are objections.

Ref: nodejs/node#13372
Ref: nodejs/node#14764
Fixes: nodejs/node#15362

@joaocgreis joaocgreis self-assigned this Sep 14, 2017
@joaocgreis
Copy link
Member Author

cc @refack @kunalspathak FYI

@refack
Copy link
Contributor

refack commented Sep 14, 2017

Refs: nodejs/node#13911 (I forgot about that)

@joaocgreis
Copy link
Member Author

Done.

Also moved x86 testing to Windows 2012, because this leaves us with few Windows 2008 with each compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants