From b91c2f5a8bada66e40f2e2c287c7f80650a67b6e Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 19 Nov 2019 18:57:44 -0500 Subject: [PATCH 1/3] doc: add minutes for meeting 19 Nov 2019 --- doc/meetings/build-wg-meeting-2019-11-19.md | 77 +++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 doc/meetings/build-wg-meeting-2019-11-19.md diff --git a/doc/meetings/build-wg-meeting-2019-11-19.md b/doc/meetings/build-wg-meeting-2019-11-19.md new file mode 100644 index 000000000..e21b97275 --- /dev/null +++ b/doc/meetings/build-wg-meeting-2019-11-19.md @@ -0,0 +1,77 @@ +# Node.js Foundation Build WorkGroup Meeting 2019-11-19 + +## Links + + +* **Recording**: https://www.youtube.com/watch?v=pm3fuQM5Yow&feature=youtu.be +* **GitHub Issue**: https://github.com/nodejs/build/issues/2046 + +## Present + + +* Michael Dawson +* Richard Lau +* Sam Roberts +* Ashley Cripps +* Rod Vagg +* Dave Ings + +## Agenda + +## Announcements + +*Extracted from **build-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + + +* Experiment with Docker + * Allow collabs to more easily manage setup, shrink the set of virtual machines that we + need to maintain + * Problem was with parallel compiles, we get occasional failures. Something about make + in docker that hits race condition. + * Michael different dockers hosts? Rod, all ubuntu 18.04 so possibly related to that. + * New version of docker might help. + * Some bugs on make issue tracker related to parallelism, but different versions used. + * Occurs across different containers versions + * To recreate, start docker, clone, run make build with -j4. Often in about 1/20. But could + related to running under jenkins + + +* Compressed pointers + * Google switching chrome over to use compressed pointers. + * May re-start discussion of multiple versions of binaries + * significant memory benefits + * build time flag, so a potential concern to make compressed version only option + * Google has not said they are removing option, but there is concern we’ll get + a lot less test coverage as only the compressed option will be used in Chrome were + the gc gets a lot of its real-world test coverage from. + + +* Metrics collection + * Started hitting 2G traffic limit on website, caused slowdowns of binary downloads + * Droplet was moved to new hardware, not sure if that was the issue as we worked + to enable caching for downloads with cloudflare + * Johan worked with his contacts got logpush enabled (typically enterprise feature). + We have to have S3 compatible storage location for logpush. Johan setup bucket + in GCP and set up. + * Rod confirmed we can get the same log data based on what is being pushed + * So downloads which were previously bypassed, are now cached + * Storage cost is not so bad, but synchronization to server to run scripts is more + Clostly. Myles is providing credits to cover cost + * Metrics are not being updated, more work to be done. + +* Update and request to board to help find resources. + * Brainstormed and sent “Job role” to board a couple of weeks ago + * Michael will present some slides to provided additional context/background + at board meeting this Friday. + + +## Q&A, Other + + +## Upcoming Meetings + + +* **Node.js Foundation Calendar**: https://nodejs.org/calendar + + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. From e68e990fe1012d224213da233b44802659dc9269 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 21 Nov 2019 18:15:03 -0500 Subject: [PATCH 2/3] Update doc/meetings/build-wg-meeting-2019-11-19.md Co-Authored-By: Richard Lau --- doc/meetings/build-wg-meeting-2019-11-19.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/meetings/build-wg-meeting-2019-11-19.md b/doc/meetings/build-wg-meeting-2019-11-19.md index e21b97275..8c536d78d 100644 --- a/doc/meetings/build-wg-meeting-2019-11-19.md +++ b/doc/meetings/build-wg-meeting-2019-11-19.md @@ -43,7 +43,7 @@ * build time flag, so a potential concern to make compressed version only option * Google has not said they are removing option, but there is concern we’ll get a lot less test coverage as only the compressed option will be used in Chrome were - the gc gets a lot of its real-world test coverage from. +* PR to add build option to Node.js to enable compressed pointers: https://github.com/nodejs/node/pull/30463 * Metrics collection From 4d736e966f943fc920dffd5a71c676103fb71cb1 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 21 Nov 2019 18:17:26 -0500 Subject: [PATCH 3/3] address comments --- doc/meetings/build-wg-meeting-2019-11-19.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/meetings/build-wg-meeting-2019-11-19.md b/doc/meetings/build-wg-meeting-2019-11-19.md index 8c536d78d..56ddc0f98 100644 --- a/doc/meetings/build-wg-meeting-2019-11-19.md +++ b/doc/meetings/build-wg-meeting-2019-11-19.md @@ -43,7 +43,8 @@ * build time flag, so a potential concern to make compressed version only option * Google has not said they are removing option, but there is concern we’ll get a lot less test coverage as only the compressed option will be used in Chrome were -* PR to add build option to Node.js to enable compressed pointers: https://github.com/nodejs/node/pull/30463 + * PR to add build option to Node.js to enable compressed pointers: https://github.com/nodejs/node/pull/30463 + * Background doc on compressed pointers in V8 https://docs.google.com/document/d/10qh2-b4C5OtSg-xLwyZpEI5ZihVBPtn1xwKBbQC26yI * Metrics collection