fix(use): create `package.json` when calling `corepack use` on empty dir #350

aduh95 · 2024-01-06T12:16:50Z

Fixes: #347

arcanis · 2024-01-08T19:56:31Z

sources/specUtils.ts

+    try {
+      file = await fs.promises.open(manifestPath, `r`);
+    } catch (err) {
+      if ((err as NodeError)?.code === `ENOENT`) continue;
+      throw err;
+    }

-    const content = await fs.promises.readFile(manifestPath, `utf8`);
+    const content = await file.readFile(`utf8`);
+    await file.close();


Can't we just use readFile and assign {} to data wen catching ENOENT?

Sure, the only anti-pattern is to rely on existsSync, as its result might be outdated by the time the readFile calls is processed.

merceyz

Could you add a test that makes sure the parent package.json is updated when ran from a sub-folder?

corepack use foo@1
mkdir src
cd src
corepack use foo@2

arcanis

Couple of nits, but LGTM overall

sources/commands/Use.ts

sources/specUtils.ts

Co-authored-by: Maël Nison <nison.mael@gmail.com>

merceyz

LGTM.

NIT: This seems more like a new feature (feat:) than a bugfix (fix:).

aduh95 · 2024-01-12T13:53:30Z

NIT: This seems more like a new feature (feat:) than a bugfix (fix:).

I chose fix because it was already the intent of the code, as you can see the 'NoProject' string was already supposed to mark the creation of a package.json. No strong feelings though

merceyz · 2024-01-12T14:02:12Z

Right, in that case I agree, it's a bugfix 👍

fix(use): create package.json when calling corepack use on empty dir

56537a5

arcanis reviewed Jan 8, 2024

View reviewed changes

Update specUtils.ts

129024b

merceyz reviewed Jan 10, 2024

View reviewed changes

aduh95 added 5 commits January 10, 2024 13:55

add test for parent dir

a697e8c

fix lint

167b382

fixup! add test for parent dir

fd74e07

fixup! fixup! add test for parent dir

6e1e11c

add nock files

c806fe2

arcanis approved these changes Jan 11, 2024

View reviewed changes

sources/commands/Use.ts Outdated Show resolved Hide resolved

sources/specUtils.ts Show resolved Hide resolved

aduh95 commented Jan 11, 2024

View reviewed changes

sources/specUtils.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

6197f46

Co-authored-by: Maël Nison <nison.mael@gmail.com>

merceyz approved these changes Jan 12, 2024

View reviewed changes

aduh95 merged commit 2950a8a into main Jan 12, 2024
9 of 10 checks passed

aduh95 deleted the fix-use-no-pk-json branch January 12, 2024 17:52

github-actions bot mentioned this pull request Jan 12, 2024

chore(main): release 0.24.1 #353

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(use): create `package.json` when calling `corepack use` on empty dir #350

fix(use): create `package.json` when calling `corepack use` on empty dir #350

aduh95 commented Jan 6, 2024

arcanis Jan 8, 2024

aduh95 Jan 8, 2024

merceyz left a comment •

edited

Loading

arcanis left a comment

merceyz left a comment •

edited

Loading

aduh95 commented Jan 12, 2024

merceyz commented Jan 12, 2024

fix(use): create package.json when calling corepack use on empty dir #350

fix(use): create package.json when calling corepack use on empty dir #350

Conversation

aduh95 commented Jan 6, 2024

arcanis Jan 8, 2024

Choose a reason for hiding this comment

aduh95 Jan 8, 2024

Choose a reason for hiding this comment

merceyz left a comment • edited Loading

Choose a reason for hiding this comment

arcanis left a comment

Choose a reason for hiding this comment

merceyz left a comment • edited Loading

Choose a reason for hiding this comment

aduh95 commented Jan 12, 2024

merceyz commented Jan 12, 2024

fix(use): create `package.json` when calling `corepack use` on empty dir #350

fix(use): create `package.json` when calling `corepack use` on empty dir #350

merceyz left a comment •

edited

Loading

merceyz left a comment •

edited

Loading