-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing WG Meeting 2015-09-25 #21
Comments
@pmuellr I would like to join in on this meeting |
I'm not sure I will be able to make it, so I will just take an observer seat. |
IN! |
@matthewloring, @AndreasMadsen - send an email for the google doc / hangout, to pmuellr@gmail.com |
I've added a number of folks for editing on the agenda doc, and on the newly created Hangouts On Air event. Let me know if you didn't see notice of this, and if the various links in the description don't work for you. |
This is the list of async_wrap issues that I could remember:
I don't know how specific the meeting should be and some of these have already been discussed. So I will let someone wiser decide. |
Guessing that @trevnorris has a fairly definitive list of async_wrap issues, but he unfortunately won't be able to make the call.
I'm not wiser, but have some comments. :-) At this point it looks like the "tracing" story has a few different angles - async_wrap, v8-tracing.h, platform specific tracing w/ETW/etc. Seems like v8-tracing.h / platform-specific tracing are kinda at the same level, and async_wrap is kinda different. I guess I see it as async_wrap will be a great place to put v8-tracing.h / platform-specific trace points. Does that seem right? If so, it would be good to come up with different "names" for these things, so we can keep straight what we're talking about, for folks coming to this as n00bs, like me. In any case, w/r/t async_wrap, using it as an exemplar of using v8/platform tracing seems ideal. We clearly want tracing hooks there. So let's talk about it some. Would also like to get an update on v8-tracing, from @ofrobots . @billti also provided some info on work to add ETW support for tracing to node, in #10, ICYMI. |
Want to make sure everyone's on the same page about
All error handling abilities were removed in the PR because of conflicts with the domain module and
My original PR addressed these cases, but unfortunately they conflicted with domains and were eventually removed because I wanted to get the native code changes merged. This can be done, but requires making calls similar to how domains work today.
This callback could not guarantee being called while the object was being destructed. Which means you would no longer have access to the object. I've toyed with an implementation in the past, but never reached a point of being useful.
This is because for performance there is a single
Probably because they are also creating a Also note there are cases like I haven't done much with |
Did you invite @bnoordhuis? He expressed interest in attending over in #19. |
It'd be good to get @yury-s in there too, so we can discuss what needs to happen to keep nodejs/node#2546 moving forward. |
I did not. I need to figure out how to maintain an email list from GH ids. And presumably Ben has a brand-new shiny IBM email id :-) Will send now. Both have email addresses in their GH profiles, so will send them a note. |
I was trying to get @fmeawad to join the meeting. He's the chrome dev working on getting trace-event into V8, but I don't think he can make this particular time-slot. |
@Qard I don't think tracing integration should be blocked by nodejs/node#2546. Once https://codereview.chromium.org/988893003/ lands into v8 it should be fairly easy to collect trace logs for v8 in Node and save them to a file. The file can be viewed with the trace-viewer by e.g. loading it into chrome:tracing We use tracing instrumentation to populate Timeline panel in DevTools. All the instrumentation is provided by tracing. DevTools only implements a fairly simple tracing agent (100 loc) that allows to convert traces via the protocol. This agent may well be integrated into v8-inspector as long as tracing support is landed in v8. Timeline panel is targeted at web developers and tries to represent tracing data in a way understandable by people not familiar with the browser guts while tracing provides more sophisticated UI and exposes way more internal details. I believe trace-viewer may be more useful for Node developers. In any case as I said v8-inspector should not block the work on integration with tracing. |
@yury-s Yep, I'm not suggesting it is a blocker. I just felt like many here would be interested in the work you are doing and might be able to lend a hand. 😄 |
Adding @natduca @paulirish @chiniforooshan |
Got the invite now (thanks @pmuellr) but I may have a conflicting schedule. Will try to join Friday but don't wait for me. |
I'm quite sure I will be able to make it. So see you on Friday. |
For anyone reading this, that's not in the list of attendees in the description of this issue (top of the web page), but wants to attend - or things they may be able to attend - please send me your email so I can add you to the Hangout. |
I've updated the invite list on the hangout to include folks I noticed on previous calls, and mentioned in this issue; you can see the invite list here: If you're not on that list, I either missed you, or couldn't find an email address for you. Either case, please send me an email you can use with Hangouts. known email-challenged folks: @fmeawad @paulirish @chiniforooshan |
Guys I think I cannot attend the call as I am in bed sick! I will try to |
@lucamaraschi yes, the Hangout should be recorded, if I don't screw up :-) |
One of the topics discussed in the meeting was setting up some spots in the repo to drop some documentation/diagrams/etc of all the various components that have been under discussion. I'll prime this with some structure this week, and then hopefully folks who understand the components can start filling in details. |
I've created an issue to track the "add docs to repo" idea - #22 |
@thlorenz: For the 'spec', the best starting point would be this comment from @natduca, and then following the linked documents from there. Here are the main components, as per my understanding:
Basically this trace-event buffer becomes the 'single pipe' through all trace-events gathered by different parts of the software stack. Once the above linked CL lands, traces being gathered in V8 will show up there. Node.js can start putting its own traces into the same pipe. I would imagine we would also need an API in Node.js to be exposed to JavaScript to allow JS code to start sending the trace events. |
I've got the meeting minutes in a PR - #23 Someone want to merge it? And give me commit access? :-) |
@pmuellr Request to join https://github.com/orgs/nodejs/teams/tracing and you should get in. |
Thanks @ofrobots will find some time to digest this all. |
I'm closing this, as the meeting has passed and the important comments have been copied or linked to in other issues now. |
Time: 3pm Friday September 25th UTC (8am Pacific), or in your local timezone: http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Tracing+WG&iso=20150925T15
Agenda and minutes can be collected in here and copied into this repo later:
https://docs.google.com/document/d/1c-mFv1WSAU4zB_p9B-5caCchv7dAqcx3kDGYVADUwgQ/edit?usp=sharing
Previous minutes: https://github.com/nodejs/tracing-wg/blob/master/wg-meetings/2015-02-19.md
Hangout on air for active participants: https://plus.google.com/hangouts/_/hoaevent/AP36tYd0g141Sb2-hvEYks-aiPi37ArGfEDhE8fQS-Gvhh03gEPQUQ
Hangout on air for viewers, event page: https://plus.google.com/events/ceccr8614j3pg3rsqcq6ev4fsik
YouTube movie for observers and saved recording: http://www.youtube.com/watch?v=yM6q92V1IDk
Current invited participants, this list is not exclusive if you think you should also join:
(will need emails for google docs/hangout setup - send to pmuellr@gmail.com)
Agenda discussion can happen in this thread.
(format copied from nodejs/Release#38)
(instructions for creating Hanouts On Air on the nodejs/node wiki)
The text was updated successfully, but these errors were encountered: