-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(make): only generate makefile for multiple toolsets if requested #133
Conversation
It's already like this in the msvs and ninja generators. Refs: nodejs/node#40934
Here's the definition of Lines 632 to 643 in 45475a7
|
The windows build failure is probably unrelated but I don't know what could be causing it:
|
Wasn't there something about a gyp change for OpenSSL 3 not making it back upstream? |
nodejs/node#40735 (raised by yourself 🙂 ) |
Right 🤦🏻 |
Can I please have some reviews? I'd like to ignore the Node.js integration errors again. We can see in nodejs/node#40934 that the patch doesn't break Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's already like this in the msvs and ninja generators.
Refs: nodejs/node#40934