Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Native proxy protocol support #16

Open
hueniverse opened this issue Apr 24, 2016 · 2 comments
Open

Native proxy protocol support #16

hueniverse opened this issue Apr 24, 2016 · 2 comments

Comments

@hueniverse
Copy link

Currently, this module: https://github.com/findhit/proxywrap tries to add support for the proxy protocol header, but it's pretty nasty hack. It replaces core node methods in order to hijack traffic to peek at it. Do you think this is something node should provide? If not, can we add some hooks to allow better solutions?

@bnoordhuis
Copy link
Member

Related (but not same) discussion: nodejs/node#1490

@hueniverse
Copy link
Author

@bnoordhuis I think the scope of proxy support is significantly different from proxy protocol header. Do you have an idea for a better solution than proxywrap? I don't consider hacking core methods to be a valid architecture for anything other than a prototype experiment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants