Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: expand ~ in install prefix early
The install prefix gets written to config.gypi and config.mk. Tildes were expanded in the first file but not in the second one, causing the `make install` target to install files to a directory named `~` in the current working directory. Fixes: #75 PR-URL: #2307 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
- Loading branch information
0bb099f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnoordhuis Should this also go on master?
0bb099f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confess to moderate confusion re: the new merging scheme. Do patches go into v3.x, then up-merged into master? Or do patches go into master and are then cherry-picked into v3.x?
0bb099f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Land in the most recent relevant branch and then cherry-pick to older versions. :)