Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Node 12/master #829

Closed
mcollina opened this issue Dec 15, 2018 · 4 comments · Fixed by #831
Closed

Support for Node 12/master #829

mcollina opened this issue Dec 15, 2018 · 4 comments · Fixed by #831

Comments

@mcollina
Copy link
Member

It seems this module has not been updated to support Node 11, and I've a fear it might not be working on Node 12/master. It's not even in CIGTM.

Because of the critical importance for older packages, can somebody expert on this check it out?

@Flarna
Copy link
Member

Flarna commented Dec 16, 2018

Regarding Node 11 NAN works fine. I created #830 to update readme and CI matrix.
But for Node 12 there is something to do as APIs have been removed/have been deprecated.

@kkoopa
Copy link
Collaborator

kkoopa commented Dec 16, 2018

I just published a long overdue update, but it does not address Node 12.

@reconbot
Copy link

@mcollina is nan not important for newer packages too?

@mcollina
Copy link
Member Author

I think nan is important for existing packages. We can’t expect packages to migrate to napi in a short timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants