Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt::ToWords docs not consistent with implementation #745

Closed
adrian-gierakowski opened this issue Jun 19, 2020 · 2 comments
Closed

BigInt::ToWords docs not consistent with implementation #745

adrian-gierakowski opened this issue Jun 19, 2020 · 2 comments

Comments

@adrian-gierakowski
Copy link

adrian-gierakowski commented Jun 19, 2020

first 2 args are swapped

the docs:

void Napi::BigInt::ToWords(size_t* word_count, int* sign_bit, uint64_t* words);

implementation:

void ToWords(int* sign_bit, size_t* word_count, uint64_t* words);

@adrian-gierakowski adrian-gierakowski changed the title BigInt docs not consistent with implementation BigInt::ToWords docs not consistent with implementation Jun 19, 2020
@NickNaso
Copy link
Member

@adrian-gierakowski Thanks for your feedback. I made a PR that fix the inconsistency with the documentation.

@NickNaso
Copy link
Member

I'm closing the issue because #748 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants