Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not building on node 8.2.1 #99

Closed
mcollina opened this issue Aug 2, 2017 · 5 comments
Closed

Not building on node 8.2.1 #99

mcollina opened this issue Aug 2, 2017 · 5 comments

Comments

@mcollina
Copy link
Member

mcollina commented Aug 2, 2017

In file included from /Users/matteo/Repositories/native-hdr-histogram/node_modules/node-addon-api/napi.h:1447:
/Users/matteo/Repositories/native-hdr-histogram/node_modules/node-addon-api/napi-inl.h:1461:20: error: no matching function for call to 'napi_create_type_error'
          status = napi_create_type_error(env, nullptr, message, &error);
                   ^~~~~~~~~~~~~~~~~~~~~~

I think this is due to a semver-major change happening in core for the new error codes. In case such events happen again, this module should be released to NPM after the change lands in a release.

@jasongin
Copy link
Member

jasongin commented Aug 2, 2017

The node-addon-api is in sync with the latest in node master. The problem is that breaking change didn't make it into an 8.x release yet. This will resolve itself in time.

@jasongin
Copy link
Member

jasongin commented Aug 2, 2017

What I meant was, the change was merged into the node 8.x branch last week, so it should be in the v8.3.0 release.

@mhdawson
Copy link
Member

Thats probably my fault as I'm generally using master versus the releases but most module maintainers are going to be using the official releases. An earlier version would probably work, but its not necessarily easy for maintainers to know. We should only have 1-2 more cases where this happens as we should be locking things down within a few weeks.

@mcollina
Copy link
Member Author

We should have a strategy to support node versions until we freeze the API.

@mhdawson
Copy link
Member

I think we can close this, please re-open if that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants