Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

JSLint errors #175

Closed
kfarnung opened this issue Feb 25, 2017 · 5 comments
Closed

JSLint errors #175

kfarnung opened this issue Feb 25, 2017 · 5 comments

Comments

@kfarnung
Copy link
Contributor

When I run tests on the xplat branch I see jslint errors. I've only tried on Windows so far.

running jslint
Collator could not be initialized and wouldn't be used

F:\GitHub\node-chakracore\test\parallel\test-buffer-slow.js
  65:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

F:\GitHub\node-chakracore\test\parallel\test-console.js
  142:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

F:\GitHub\node-chakracore\test\parallel\test-intl.js
  80:10  error  '+' should be placed at the end of the line  operator-linebreak

F:\GitHub\node-chakracore\test\parallel\test-require-json.js
  10:15  error  Unnecessary regex escape in character class: \/  no-useless-regex-char-class-escape
  10:29  error  Unnecessary regex escape in character class: \/  no-useless-regex-char-class-escape
  12:11  error  Unnecessary regex escape in character class: \/  no-useless-regex-char-class-escape
  12:25  error  Unnecessary regex escape in character class: \/  no-useless-regex-char-class-escape

F:\GitHub\node-chakracore\test\sequential\test-module-loading.js
  78:1  error  Line 78 exceeds the maximum line length of 80  max-len
  79:1  error  Line 79 exceeds the maximum line length of 80  max-len

F:\GitHub\node-chakracore\test\tmp.6\中文目录\file.js
  1:1   error  Use the global form of 'use strict'            strict
  1:1   error  Mandatory module "common" must be loaded       required-modules
  1:21  error  Newline required at end of file but not found  eol-last

✖ 12 problems (12 errors, 0 warnings)
@kfarnung
Copy link
Contributor Author

@digitalinfinity FYI

@kfarnung
Copy link
Contributor Author

The last set seem to be the by-product of a test run:

F:\GitHub\node-chakracore\test\tmp.6\中文目录\file.js
  1:1   error  Use the global form of 'use strict'            strict
  1:1   error  Mandatory module "common" must be loaded       required-modules
  1:21  error  Newline required at end of file but not found  eol-last

@digitalinfinity
Copy link
Contributor

@kunalspathak can you see if these still show up after your merge? It would be good to understand the root cause of these errors

@kunalspathak
Copy link
Member

@kunalspathak can you see if these still show up after your merge?

Nope. i don't see any of those.

By the way, if any of you noticed below text in the output that @kfarnung pasted , I have opened chakra-core/ChakraCore#2604 to track it

Collator could not be initialized and wouldn't be used

@kfarnung
Copy link
Contributor Author

kfarnung commented Apr 29, 2017

Other than the occasional test file failure, I'm not seeing any jslint issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants