Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-node-land: lease? #172

Closed
srl295 opened this issue Feb 10, 2018 · 3 comments
Closed

git-node-land: lease? #172

srl295 opened this issue Feb 10, 2018 · 3 comments
Labels
git-node question stale

Comments

@srl295
Copy link
Member

srl295 commented Feb 10, 2018

Per the collaborator's guide, I end up with:

$ git push --force-with-lease srl295 master:icu-add-using

this gives the little purple "merged" badge as per nodejs/node#18667 thus not needing to close the PR yourself with "Landed in b8f47b27571f8d763f811f017be3fb37d466c4fc"

could/should the tool suggest this step?
@srl295 srl295 changed the title lease? git-node-land: lease? Feb 10, 2018
@srl295
Copy link
Member Author

srl295 commented Oct 24, 2018

I realized the tool doesn't a priori know which my branch is. But, it could find it from github metadata on the PR.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 17, 2020
@codebytere
Copy link
Member

Duplicate of #264

@codebytere codebytere marked this as a duplicate of #264 Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git-node question stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srl295 @codebytere @priyank-p