Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-node: err in CI date math #338

Closed
srl295 opened this issue Apr 26, 2019 · 3 comments
Closed

git-node: err in CI date math #338

srl295 opened this issue Apr 26, 2019 · 3 comments

Comments

@srl295
Copy link
Member

srl295 commented Apr 26, 2019

node-core-utils@1.16.1

My PR: nodejs/node#27370

   ℹ  Last Lite PR Pipeline CI on 2019-04-23T17:04:57Z: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3341
   ℹ  Last Full PR CI on 2019-04-24T22:27:33Z: https://ci.nodejs.org/job/node-test-pull-request/22696/

but I kept getting:

⚠ Commits were pushed after the last Lite PR Pipeline CI run:

debugging i see:

{ committedDate: '2019-04-24T21:44:09Z'
a461aa39d098930d668298480cd415569e92f53a

lastCI:
{ typeName: 'Lite PR Pipeline', date: '2019-04-23T17:04:57Z' } }

so the 'lastCI' is the lite one on the 23rd, not the full on the 24th 1 hour after the fact.

===Found it===

I think this is the bug, pr_checker.js:199

       if (!lastCI || lastCI.date > ci.date) {

this will only replace a CI if it is newer we have

       if (!lastCI || lastCI.date < ci.date) {
@richardlau
Copy link
Member

This was fixed in #334 but we haven't had a release containing it.

@srl295
Copy link
Member Author

srl295 commented Apr 26, 2019

oops dup of #334

@srl295 srl295 closed this as completed Apr 26, 2019
@srl295
Copy link
Member Author

srl295 commented Apr 26, 2019

duplicate comment also..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants