Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retrieve more than the last 10 checkSuites #476

Closed
mmarchini opened this issue Aug 15, 2020 · 6 comments
Closed

Should retrieve more than the last 10 checkSuites #476

mmarchini opened this issue Aug 15, 2020 · 6 comments
Assignees

Comments

@mmarchini
Copy link
Contributor

We have 12 check suites today on Node.js, which means we're not retrieving all suites to check if they passed (well, after #469 lands). We're retrieving 100 commits for the PR, which is unlikely to happen, so it's probably a good idea to shift from commits to checkSuites (maybe 25 commits / 40 check suites).

@mmarchini mmarchini self-assigned this Aug 15, 2020
@targos
Copy link
Member

targos commented Aug 15, 2020

Maybe still 50 commits? V8 updates often come close to 25.

@mmarchini
Copy link
Contributor Author

Yeah, I'll tweak with it to use the graphql fetch limit (we'll probably go over 20 actions at some point). Although I'm not sure we use the commits (except the last) on any checks.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 14, 2020
@mmarchini mmarchini removed the stale label Nov 14, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Feb 13, 2021
@codebytere
Copy link
Member

@mmarchini mind if i do this?

@codebytere codebytere removed the stale label Feb 17, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 11, 2023

Fixed by e98d72e

@aduh95 aduh95 closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants