-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce/restrict scope of the project? #480
Comments
I personally would be in favor of demarcating scope limits along these lines for the same reasons, as well as to help ensure that decisions around what features we do and don't add (and workarounds) are more clearly enumerated. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
I would suggest reopen this. Currently I have to maintain a fork of this to make life easier. executing ✖ Failed to get collaborator info from nodejs/node-gyp/README.md
Error: Couldn't find ### TSC (Technical Steering Committee) in the README
at parseCollaborators (/usr/local/share/.config/yarn/global/node_modules/node-core-utils/lib/collaborators.js:83:11)
at getCollaborators (/usr/local/share/.config/yarn/global/node_modules/node-core-utils/lib/collaborators.js:61:21)
at processTicksAndRejections (node:internal/process/task_queues:93:5)
at async PRData.getCollaborators (/usr/local/share/.config/yarn/global/node_modules/node-core-utils/lib/pr_data.js:77:26)
at async Promise.all (index 0)
at async PRData.getAll (/usr/local/share/.config/yarn/global/node_modules/node-core-utils/lib/pr_data.js:61:5)
at async getMetadata (/usr/local/share/.config/yarn/global/node_modules/node-core-utils/components/metadata.js:20:3) fixing #373 really need this. also cc @richardlau @rvagg |
Yeah, I do all of node-gyp's metadata manually, that's still in my muscle memory from old-timey nodejs/node commit merging, but it does get pretty tedious and is probably one of the reasons I delay a lot of merging. Does this just need someone to do the work to enable this for alternative repos while not exposing that complexity to the common use-case of nodejs/node maintenance? That's the approach I took with branch-diff and changelog-maker -- they're made for nodejs/node by default (there's some URL inference in there if there's incomplete information) but they're also perfectly usable for any other repo if you have everything in order. |
node-core-utils
has's been used to land PRs on some WGs from time to time, as well as some projects like llnode. None of those projects really need to follownodejs/node
landing flow though. Based on some comments on #469, I'm wondering if we should reduce the scope of this project to only land pull requests onnodejs/node
, instead of aiming to land any pull requests on any projects in the org. This should help us reduce some complexity in the code base (such as multiple CI providers) as well as reduce frustration from trying to use it on other repositories (which always need some workaround) and allow us to filter out feature requests that are not targeted atnodejs/node
(such as #373).We would need to update some documentations to clarify that, and doing so could be considered a breaking change to the project.
The text was updated successfully, but these errors were encountered: