Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to clone v8 on 20.7.0 #743

Closed
H4ad opened this issue Oct 10, 2023 · 5 comments · Fixed by #756
Closed

Fail to clone v8 on 20.7.0 #743

H4ad opened this issue Oct 10, 2023 · 5 comments · Fixed by #756

Comments

@H4ad
Copy link
Member

H4ad commented Oct 10, 2023

I tried:

git node v8 backport 6584b6 

But received:

⠋ Update local V8 clone
◼ V8 commit backport
node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: spawn git ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn git',
  path: 'git',
  spawnargs: [ 'fetch', 'origin' ]
}

Node.js v20.7.0

From what I read from the code, the v8 folder should be created and then the v8 should be cloned.

I tried on node 20.1.0 and the clone works, so maybe there is some behavior that changed between 20.1.0 and 20.7.0

@H4ad H4ad changed the title Fail to clone v8 Fail to clone v8 on 20.7.0 Oct 10, 2023
@aduh95
Copy link
Contributor

aduh95 commented Oct 14, 2023

The error message indicates that git is not available on the $PATH, I don't think it's related to the version of Node.js you use.

@richardlau
Copy link
Member

@abmusse ran into a similar problem with current versions of node-core-utils. @H4ad can you try with node-core-utils@3.3.0 and see if the problems occurs with that version?

@H4ad
Copy link
Member Author

H4ad commented Oct 15, 2023

@richardlau 3.3.0 works, 3.5.0 I got the same error.

@aduh95
Copy link
Contributor

aduh95 commented Oct 16, 2023

Probably related to #722, can you confirm wether you still see the error if you first clone the V8 repo and pass it to --v8-dir?

@H4ad
Copy link
Member Author

H4ad commented Oct 17, 2023

@aduh95 If I first clone and then --v8-dir, it works without problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants