Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: landing session on different repo/org #847

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

RafaelGSS
Copy link
Member

This allows the git node land usage on different forks. It might also help on nodejs-private.

@RafaelGSS RafaelGSS force-pushed the fix-landing-session branch from bc9b470 to 7ee744c Compare August 28, 2024 19:17
@RafaelGSS RafaelGSS changed the title lib: fix landing session on different repo/org fix: landing session on different repo/org Aug 28, 2024
@aduh95
Copy link
Contributor

aduh95 commented Aug 29, 2024

It's not obvious (IMO) how this change is related to landing session on different repo/org, could you explain?

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Aug 29, 2024

It's not obvious (IMO) how this change is related to landing session on different repo/org, could you explain?

When you use git node land https://github.com/ANOTHER-ORG/ANOTHER-REPO/pull/12345 it just ignores the argv because we are not passing argv to Session as it's specified in https://github.com/nodejs/node-core-utils/blob/main/lib/session.js#L18

So, when we attempt to read PRData we use the default argv instead of the expected argv (owner/repo)

const metadata = await getMetadata(session.argv, argv.skipRefs, cli);
.

@RafaelGSS RafaelGSS merged commit 7734954 into nodejs:main Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants