Skip to content

Commit

Permalink
Use result of which when searching for python.
Browse files Browse the repository at this point in the history
Fixes: #667
Fixes: #750
PR-URL: #668
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
Refael Ackermann authored and bnoordhuis committed Nov 24, 2015
1 parent 817ed9b commit 268f1ca
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/configure.js
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,10 @@ function findPython (python, callback) {
}
} else {
log.verbose('`which` succeeded', python, execPath)
// Found the `python` exceutable, and from now on we use it explicitly.
// This solves #667 and #750 (`execFile` won't run batch files
// (*.cmd, and *.bat))
python = execPath
checkPythonVersion()
}
})
Expand Down

0 comments on commit 268f1ca

Please sign in to comment.