Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful node path detection. #1408

Closed
jdalton opened this issue Apr 6, 2018 · 2 comments
Closed

Graceful node path detection. #1408

jdalton opened this issue Apr 6, 2018 · 2 comments

Comments

@jdalton
Copy link
Member

jdalton commented Apr 6, 2018

With issues like nodejs/node#19840 and npm/npm#20163 I thought it would be good to start thinking of ways to better handle node-gyp resolution of the Node path as well as how it can have folks like Node and npm rely on it without stepping on each others toes.

File of interest:
lib/find-node-directory.js.

\cc @iarna from npm and @addaleax @MylesBorins from Node.

@MylesBorins
Copy link
Contributor

Looks like npm opened a PR to bing the dependency back to the main tree and introducing a test to not regress in the future

npm/npm#20276

@rvagg
Copy link
Member

rvagg commented Jun 20, 2019

addressed in npm/npm#20276 I suppose

@rvagg rvagg closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants