-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <RuntimeTypeInfo>false</RuntimeTypeInfo>
from visual studio project release configuration
#335
Comments
Could I please know why this was closed? |
Pardon, I misread the merged changeset as a fix that was integrated. Can you submit this as a pull request please? |
I tried but this project is really complex and I couldn't find exactly where it was coming from |
Fair enough. The vcproj files are generated down in the Gyp layer -- node-gyp includes a copy of gyp but does not modify the vcproj file generation itself. If you can put a little more detail into this bug on reproducing the issue I will try and hunt down the problem in gyp and get a patch submitted there. |
The referenced issues above provide a bit of details but the actual reason eludes me a bit. In essence we discovered that when the binaries were compiled in debug mode for node-sass everything worked fine but when it was compiled in release mode, the binary would fails on many instances without any errors. That parameters was the one I isolated that caused the issue. I"m not sure what it does and why node requires RuntimeTypeInfo though. |
The description from Microsoft isn't very helpful either |
The trick here is that the way to override this option is not obvious. But it can be done so this is not a node-gyp bug AFAICT. It looks like the node-sass project figured out a way in sass/node-sass@ca801d1#diff-21e418851ae48f9b11907837add9e39a and I've confirmed that this works. |
See also #330 |
Yes so do I. One could argue that node-gyp should output the best configuration it can. That fix is mostly a workaround. |
I think this can be closed. In the recent versions of node-sass we separate binding configuration (binding.gyp) which closely matches how node itself has been compiled and libsass.gyp which builds the C++11 library with lots of bells and whistles (rtti, exceptions, etc.). We supply now appropriate /GR and /EH options to the Visual Studio. Most importantly, there is little that node-gyp can do better., except for better handling of desirable overrides #26 (in the comments). |
This option was causing all sorts of problem with node-sass. I discovered this problem because the debug version worked but not the release. I arrowed it down to this option.
The text was updated successfully, but these errors were encountered: