From ae0be8745db6c6c94f9e670f1638bc2c99303982 Mon Sep 17 00:00:00 2001 From: cclauss Date: Tue, 14 Nov 2017 07:56:07 +0100 Subject: [PATCH 1/2] gyp: fix sntex error PR-URL: https://github.com/nodejs/node-gyp/pull/1333 Reviewed-By: Refael Ackermann --- gyp/pylib/gyp/mac_tool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gyp/pylib/gyp/mac_tool.py b/gyp/pylib/gyp/mac_tool.py index b8f38a8fdc..b8b7344eff 100755 --- a/gyp/pylib/gyp/mac_tool.py +++ b/gyp/pylib/gyp/mac_tool.py @@ -127,7 +127,7 @@ def _DetectInputEncoding(self, file_name): fp = open(file_name, 'rb') try: header = fp.read(3) - except e: + except Exception: fp.close() return None fp.close() From 2394a1eca27bfc99e03f899034783287f17c6b08 Mon Sep 17 00:00:00 2001 From: cclauss Date: Tue, 14 Nov 2017 09:00:29 +0100 Subject: [PATCH 2/2] gyp: fix target --> self.target target is an undefined name in this context. https://github.com/nodejs/node-gyp/pull/1334 Reviewed-By: Refael Ackermann --- gyp/pylib/gyp/generator/make.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gyp/pylib/gyp/generator/make.py b/gyp/pylib/gyp/generator/make.py index cfc7b05433..d549e899d8 100644 --- a/gyp/pylib/gyp/generator/make.py +++ b/gyp/pylib/gyp/generator/make.py @@ -1639,7 +1639,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps, self.WriteDoCmd([self.output_binary], deps, 'touch', part_of_all, postbuilds=postbuilds) else: - print("WARNING: no output for", self.type, target) + print("WARNING: no output for", self.type, self.target) # Add an alias for each target (if there are any outputs). # Installable target aliases are created below.