Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

backport NODE_DEPRECATED fixes from io.js #25267

Closed
misterdjules opened this issue May 7, 2015 · 2 comments
Closed

backport NODE_DEPRECATED fixes from io.js #25267

misterdjules opened this issue May 7, 2015 · 2 comments
Labels
P-2 S-confirmed-bug v0.12

Comments

@misterdjules
Copy link

@bnoordhuis has fixed the NODE_DEPRECATED macro which wasn't effective anymore (@trevnorris had already spotted this a while ago). There's another change that fix a problem when the first change would trigger a compilation error on older compilers.

I suggest porting both changes in v0.12.

/cc @joyent/node-coreteam.
@cjihrig
Copy link

cjihrig commented May 7, 2015

+1 to both commits.

@jasnell
Copy link
Member

jasnell commented May 12, 2015

+1

@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P-2 S-confirmed-bug v0.12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasnell @Trott @misterdjules @cjihrig