Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

v0.12: Poor choice of V8 version #9241

Closed
jakobkummerow opened this issue Feb 18, 2015 · 4 comments
Closed

v0.12: Poor choice of V8 version #9241

jakobkummerow opened this issue Feb 18, 2015 · 4 comments
Assignees
Milestone

Comments

@jakobkummerow
Copy link

I just happened to notice that node v0.12 ships V8 3.28.73. That's a pretty bad choice, as 3.28.73 was just a random trunk snapshot that was briefly considered as the basis for the 3.28 branch, but was then discarded/abandoned because it was too unstable. The tip of the branch is 3.28.71.19: https://chromium.googlesource.com/v8/v8.git/+/branch-heads/3.28

While the 3.28 branch is generally outdated and hence unmaintained anyway, at least using its tip is very strongly preferable over using a random trunk commit from shortly after the branch point. To be very clear: There are known crash and security bugs in 3.28.73 that are fixed in 3.28.71.19!

@kenany
Copy link

kenany commented Feb 18, 2015

#9185?

@jakobkummerow
Copy link
Author

Ah. Well, I would recommend to ship that ASAP.

@misterdjules
Copy link

Thanks @jakobkummerow for your input. Assigning to @trevnorris as he's already working on #9185.

@misterdjules
Copy link

Fixed by 32166a9, beff91c, ace398e, 9a960c2 5b2bf92 and 712cb43, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants