Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on Windows #207

Closed
targos opened this issue Sep 7, 2021 · 4 comments
Closed

Build error on Windows #207

targos opened this issue Sep 7, 2021 · 4 comments

Comments

@targos
Copy link
Member

targos commented Sep 7, 2021

D:\a\node-v8\node-v8\deps\v8\src\parsing\parser-base.h(1097,29): error C2039: 'PreParserIdentifierToAstRawString': is not a member of 'v8::internal::Parser' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\parsing\parser.h(131): message : see declaration of 'v8::internal::Parser' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\parsing\parser-base.h(1095): message : while compiling class template member function 'void v8::internal::ParserBase<v8::internal::Parser>::ReportMessageAt(v8::internal::Scanner::Location,v8::internal::MessageTemplate,const v8::internal::PreParserIdentifier &)' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\parsing\parser.h(131): message : see reference to class template instantiation 'v8::internal::ParserBase<v8::internal::Parser>' being compiled [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

https://github.com/nodejs/node-v8/runs/3531095572?check_suite_focus=true

@targos
Copy link
Member Author

targos commented Sep 7, 2021

11:40:33 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser-base.h(1097,29): error C2039: 'PreParserIdentifierToAstRawString': is not a member of 'v8::internal::Parser' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:33   graph.cc
11:40:33 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser.h(131): message : see declaration of 'v8::internal::Parser' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:33 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser-base.h(1095): message : while compiling class template member function 'void v8::internal::ParserBase<v8::internal::Parser>::ReportMessageAt(v8::internal::Scanner::Location,v8::internal::MessageTemplate,const v8::internal::PreParserIdentifier &)' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:33 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser.h(131): message : see reference to class template instantiation 'v8::internal::ParserBase<v8::internal::Parser>' being compiled [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:41   api-natives.cc
11:40:41   prettyprinter.cc
11:40:41   api.cc
11:40:41 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser-base.h(1097,29): error C2039: 'PreParserIdentifierToAstRawString': is not a member of 'v8::internal::Parser' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:41 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser.h(131): message : see declaration of 'v8::internal::Parser' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:41 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser-base.h(1095): message : while compiling class template member function 'void v8::internal::ParserBase<v8::internal::Parser>::ReportMessageAt(v8::internal::Scanner::Location,v8::internal::MessageTemplate,const v8::internal::PreParserIdentifier &)' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
11:40:41 C:\workspace\node-compile-windows-debug\node\deps\v8\src\parsing\parser.h(131): message : see reference to class template instantiation 'v8::internal::ParserBase<v8::internal::Parser>' being compiled [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

https://ci.nodejs.org/job/node-compile-windows-debug/9405/nodes=win-vs2019/console

@DerekNonGeneric
Copy link

Yeah, pretty sure that this is preventing green CI for everyone at the moment… I do not know what needs to be done to fix it, but it is annoying (let me know if there is anything I can do — fortunately I have a Windows Machine w/ active licenses that were provided to me by my school.)

@targos
Copy link
Member Author

targos commented Sep 7, 2021

pretty sure that this is preventing green CI for everyone at the moment

This is only with V8 canary. It has no impact on CI for nodejs/node.

@targos
Copy link
Member Author

targos commented Sep 22, 2021

Moving to nodejs/node#40178

@targos targos closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants