node-api: explicitly set __cdecl for API functions

PR-URL: #42780 Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs · May 16, 2022 · 037ff3d · 037ff3d
1 parent c535db1
commit 037ff3d
Show file tree

Hide file tree

Showing 6 changed files with 973 additions and 908 deletions.
diff --git a/src/js_native_api.h b/src/js_native_api.h
diff --git a/src/js_native_api_types.h b/src/js_native_api_types.h
@@ -11,6 +11,14 @@
 typedef uint16_t char16_t;
 #endif
 
+#ifndef NAPI_CDECL
+#ifdef _WIN32
+#define NAPI_CDECL __cdecl
+#else
+#define NAPI_CDECL
+#endif
+#endif
+
 // JSVM API types are all opaque pointers for ABI stability
 // typedef undefined structs instead of void* for compile time type safety
 typedef struct napi_env__* napi_env;
@@ -100,10 +108,11 @@ typedef enum {
 //   * the definition of `napi_status` in doc/api/n-api.md to reflect the newly
 //     added value(s).
 
-typedef napi_value (*napi_callback)(napi_env env, napi_callback_info info);
-typedef void (*napi_finalize)(napi_env env,
-                              void* finalize_data,
-                              void* finalize_hint);
+typedef napi_value(NAPI_CDECL* napi_callback)(napi_env env,
+                                              napi_callback_info info);
+typedef void(NAPI_CDECL* napi_finalize)(napi_env env,
+                                        void* finalize_data,
+                                        void* finalize_hint);
 
 typedef struct {
   // One of utf8name or name should be NULL.