From 05b8526a594db8be5621ea40de625c46fcd5f1dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 18 Jun 2019 08:00:00 +0200 Subject: [PATCH] deps: V8: extend workaround for MSVC optimizer bug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds are starting to fail in CI with V8 7.5 and 7.6. Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: https://github.com/nodejs/node/pull/28286 Reviewed-By: Bartosz Sosnowski Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann (רפאל פלחי) Reviewed-By: Ruben Bridgewater --- deps/v8/src/builtins/setup-builtins-internal.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deps/v8/src/builtins/setup-builtins-internal.cc b/deps/v8/src/builtins/setup-builtins-internal.cc index 25e29b87634bff..a9d260372c3952 100644 --- a/deps/v8/src/builtins/setup-builtins-internal.cc +++ b/deps/v8/src/builtins/setup-builtins-internal.cc @@ -297,7 +297,7 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index, } // namespace -#if _MSC_VER == 1920 +#ifdef _MSC_VER #pragma optimize( "", off ) #endif @@ -384,7 +384,7 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) { builtins->MarkInitialized(); } -#if _MSC_VER == 1920 +#ifdef _MSC_VER #pragma optimize( "", on ) #endif