Skip to content

Commit

Permalink
lib: rename internal module declaration as internal bindings
Browse files Browse the repository at this point in the history
This is a follow-up to #45551 .

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to
be adopted.

PR-URL: #46663
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
okmttdhr authored and danielleadams committed Apr 11, 2023
1 parent c6e722a commit 06e0dd3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/loaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// NM_F_LINKED.
// - internalBinding(): the private internal C++ binding loader, inaccessible
// from user land unless through `require('internal/test/binding')`.
// These C++ bindings are created using NODE_MODULE_CONTEXT_AWARE_INTERNAL()
// These C++ bindings are created using NODE_BINDING_CONTEXT_AWARE_INTERNAL()
// and have their nm_flags set to NM_F_INTERNAL.
//
// Internal JavaScript module loader:
Expand Down

0 comments on commit 06e0dd3

Please sign in to comment.