Skip to content

Commit

Permalink
doc: writableFinished is true before 'finish'
Browse files Browse the repository at this point in the history
PR-URL: #28811
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
ronag authored and targos committed Aug 2, 2019
1 parent c389526 commit 0ac6d28
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion doc/api/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,9 @@ added: v12.7.0

* {boolean}

Is `true` if all data has been flushed to the underlying system.
Is `true` if all data has been flushed to the underlying system, immediately
before the [`'finish'`][] event is emitted.


### response.writeContinue()
<!-- YAML
Expand Down Expand Up @@ -2197,6 +2199,7 @@ not abort the request or do anything besides add a `'timeout'` event.
[`agent.createConnection()`]: #http_agent_createconnection_options_callback
[`agent.getName()`]: #http_agent_getname_options
[`destroy()`]: #http_agent_destroy
[`'finish'`]: #http_event_finish
[`getHeader(name)`]: #http_request_getheader_name
[`http.Agent`]: #http_class_http_agent
[`http.ClientRequest`]: #http_class_http_clientrequest
Expand Down
2 changes: 1 addition & 1 deletion doc/api/stream.md
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ added: v12.6.0

* {boolean}

Is `true` if after the [`'finish'`][] event has been emitted.
Is set to `true` immediately before the [`'finish'`][] event is emitted.

##### writable.writableHighWaterMark
<!-- YAML
Expand Down

0 comments on commit 0ac6d28

Please sign in to comment.