Skip to content

Commit

Permalink
test: fix test-tls-server-verify.js on Windows CI
Browse files Browse the repository at this point in the history
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Trott authored and evanlucas committed Jan 30, 2018
1 parent 230a102 commit 1458e51
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test/parallel/test-tls-server-verify.js
Original file line number Diff line number Diff line change
@@ -327,7 +327,7 @@ function runTest(port, testIndex) {
} else {
server.close();
successfulTests++;
runTest(port, nextTest++);
runTest(0, nextTest++);
}
}

@@ -345,7 +345,7 @@ function runTest(port, testIndex) {
if (clientsCompleted === tcase.clients.length) {
server.close();
successfulTests++;
runTest(port, nextTest++);
runTest(0, nextTest++);
}
});
}
@@ -356,7 +356,6 @@ function runTest(port, testIndex) {

let nextTest = 0;
runTest(0, nextTest++);
runTest(0, nextTest++);


process.on('exit', function() {

0 comments on commit 1458e51

Please sign in to comment.