From 16cbd8c8b6e1df4fb94c412fed544b37674261be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 30 Jan 2021 13:29:59 +0100 Subject: [PATCH] deps: silence irrelevant V8 warnings PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: Myles Borins --- common.gypi | 2 +- deps/v8/include/v8.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index fbee26b668143a..a4f7e9d5aede99 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.5', + 'v8_embedder_string': '-node.6', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 96c6b4a11d5ab6..464ced97679881 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -1653,7 +1653,7 @@ class V8_EXPORT Module : public Data { */ int GetIdentityHash() const; - using ResolveCallback V8_DEPRECATE_SOON("Use ResolveModuleCallback") = + using ResolveCallback = MaybeLocal (*)(Local context, Local specifier, Local referrer); using ResolveModuleCallback = MaybeLocal (*)( @@ -7299,8 +7299,7 @@ using CallCompletedCallback = void (*)(Isolate*); * fails (e.g. due to stack overflow), the embedder must propagate * that exception by returning an empty MaybeLocal. */ -using HostImportModuleDynamicallyCallback V8_DEPRECATE_SOON( - "Use HostImportModuleDynamicallyWithImportAssertionsCallback instead") = +using HostImportModuleDynamicallyCallback = MaybeLocal (*)(Local context, Local referrer, Local specifier);