From 1bda58289a1256b154e6ae15db23db83a3e6d130 Mon Sep 17 00:00:00 2001
From: Ujjwal Sharma <usharma1998@gmail.com>
Date: Thu, 29 Mar 2018 08:18:03 +0530
Subject: [PATCH] test: rename regression tests more expressively

- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero
- Rename test-process-exit-GH-12322 to test-process-exit-handler

PR-URL: https://github.com/nodejs/node/pull/19668
Refs: https://github.com/nodejs/node/issues/19105
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 ...js => test-fs-truncate-clear-file-zero.js} | 20 +++++++++++++------
 test/parallel/test-process-exit-GH-12322.js   |  7 -------
 test/parallel/test-process-exit-handler.js    | 11 ++++++++++
 3 files changed, 25 insertions(+), 13 deletions(-)
 rename test/parallel/{test-fs-truncate-GH-6233.js => test-fs-truncate-clear-file-zero.js} (81%)
 delete mode 100644 test/parallel/test-process-exit-GH-12322.js
 create mode 100644 test/parallel/test-process-exit-handler.js

diff --git a/test/parallel/test-fs-truncate-GH-6233.js b/test/parallel/test-fs-truncate-clear-file-zero.js
similarity index 81%
rename from test/parallel/test-fs-truncate-GH-6233.js
rename to test/parallel/test-fs-truncate-clear-file-zero.js
index 87663c63616ffa..4f3dce90995d06 100644
--- a/test/parallel/test-fs-truncate-GH-6233.js
+++ b/test/parallel/test-fs-truncate-clear-file-zero.js
@@ -21,11 +21,15 @@
 
 'use strict';
 const common = require('../common');
+const tmpdir = require('../common/tmpdir');
+
+// This test ensures that `fs.truncate` opens the file with `r+` and not `w`,
+// which had earlier resulted in the target file's content getting zeroed out.
+// https://github.com/nodejs/node-v0.x-archive/issues/6233
+
 const assert = require('assert');
 const fs = require('fs');
 
-const tmpdir = require('../common/tmpdir');
-
 const filename = `${tmpdir.path}/truncate-file.txt`;
 
 tmpdir.refresh();
@@ -42,8 +46,12 @@ tmpdir.refresh();
 {
   fs.writeFileSync(filename, '0123456789');
   assert.strictEqual(fs.readFileSync(filename).toString(), '0123456789');
-  fs.truncate(filename, 5, common.mustCall(function(err) {
-    assert.ifError(err);
-    assert.strictEqual(fs.readFileSync(filename).toString(), '01234');
-  }));
+  fs.truncate(
+    filename,
+    5,
+    common.mustCall(function(err) {
+      assert.ifError(err);
+      assert.strictEqual(fs.readFileSync(filename).toString(), '01234');
+    })
+  );
 }
diff --git a/test/parallel/test-process-exit-GH-12322.js b/test/parallel/test-process-exit-GH-12322.js
deleted file mode 100644
index 890dfd4df7bff4..00000000000000
--- a/test/parallel/test-process-exit-GH-12322.js
+++ /dev/null
@@ -1,7 +0,0 @@
-'use strict';
-require('../common');
-
-process.on('exit', () => {
-  setTimeout(process.abort, 0);  // Should not run.
-  for (const start = Date.now(); Date.now() - start < 10; /* Empty. */);
-});
diff --git a/test/parallel/test-process-exit-handler.js b/test/parallel/test-process-exit-handler.js
new file mode 100644
index 00000000000000..22d84f34349b73
--- /dev/null
+++ b/test/parallel/test-process-exit-handler.js
@@ -0,0 +1,11 @@
+'use strict';
+require('../common');
+
+// This test ensures that no asynchronous operations are performed in the 'exit'
+// handler.
+// https://github.com/nodejs/node/issues/12322
+
+process.on('exit', () => {
+  setTimeout(process.abort, 0); // Should not run.
+  for (const start = Date.now(); Date.now() - start < 10;);
+});